search

exercism / php-test-runner

GNU Affero General Public License v3.0
0 stars 6 forks source link

handle php fatal error #26

Closed neenjaw closed 2 years ago

neenjaw commented 2 years ago

Pointed out in slack that when PHP encounters fatal error before phpunit able to return, the test runner is mistakenly passing the solution.

This is because the junit parser junit-to-json is receiving an empty file without failing tests.

run.sh now catches php fatal error code 255, and returns proper test runner output with error message to test organizer.

neenjaw commented 2 years ago

@iHiD / @ErikSchierboom / @Saschamann

This is the fix for the bug that Kirill found on slack. I think the two actions are failing because of the action/cache step which seems linked to changes in the package.json, but I need it to also flush the cache with changes to the Docker file. Do you know how to do this?

neenjaw commented 2 years ago

Thanks @ErikSchierboom! You're right, I was just missing installing jo. 🤦🏻 Tried substituting the line you suggested, seems that the image doesn't have "docker" so it can;t run another docker instance inside it. 🤷🏻 So I just added a step to grab the package.

Will look into the docker step later, as this works for now. 😄