exercism / php

Exercism exercises in PHP.
https://exercism.org/tracks/php
MIT License
141 stars 137 forks source link

Coordination: Upgrade to PHP 8.1 - 8.3 and PHPUnit 10 #652

Open mk-mxp opened 6 months ago

mk-mxp commented 6 months ago

This is what I think must be done:

Post-upgrade to modernize further:

In the whole process, try to avoid re-running the representer and not to trigger re-testing all community solutions. These are very costly to Exercism.

tomasnorre commented 6 months ago

I can look into the first 3 and group them in one PR one of the next days.

The first 3 should be covered in https://github.com/exercism/php/pull/656 The PHP Test Runner PR https://github.com/exercism/php-test-runner/pull/100

The php-representer I don't know enough about to take care of. Update: I have looked a little into the PHP presenter, but as the tests even online, when looking into the logs are failing, it's hard to tell when the job is correctly done. So I would prefer someone with more knowledge about the presenter to handle this bit.

tomasnorre commented 6 months ago

I don't know if it belongs in this to-do list, but still some exercises, probably older ones, have snake cases in the Stub files. I would prefer having them using camel case too, like the standard is today.

E.g. the https://github.com/exercism/php/blob/main/exercises/concept/lasagna/Lasagna.php

mk-mxp commented 6 months ago

I haven't written documentation on this, yet: We use snake_case for functions, camelCase for methods and PascalCase for classes.

Edit: There is no "standard" defined for variable names, yet. And you may make this a separate issue, has nothing to do with PHP updates.