Closed fejan-malek closed 1 month ago
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
[no important files changed]
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin
in a comment. Thank you!
@fejan92 Are you still working on this? Click "Re-request review" next to my name in "Reviewers" when you are done.
Needs to be done for
Decide on adding / adjusting / ordering test cases to match current problem specs
I took a look into the existing solutions. It is OK to add the missing test as specified in canonical-data.json
https://github.com/exercism/problem-specifications/blob/main/exercises/rna-transcription/canonical-data.json The expected value you used is not OK.
canonical-data.json
I have update the test cases here. For canonical-data.json
I need to clone that project and update the test cases there also.
Only input
and expected
remain to add in textdoc documentation
Please tell me if the below is proper documentation after that I will update in the test file
/**
* @testdox RNA complement
* @input UGCACCAGAAUU
* @expected UCGGCCGUGAAAU
* uuid 79ed2757-f018-4f47-a1d7-34a559392dbf
*/
public function testTranscribesAllOccurrencesOne(): void
{
...body
}
Only
input
andexpected
remain to add in textdoc documentationPlease tell me if the below is proper documentation after that I will update in the test file
/** * @testdox RNA complement * @input UGCACCAGAAUU * @expected UCGGCCGUGAAAU * uuid 79ed2757-f018-4f47-a1d7-34a559392dbf */ public function testTranscribesAllOccurrencesOne(): void { ...body }
No, thanks. Don't do that.
Thank you.
Hope I am not messing up things. Yes as a beginner I am making mistakes.
Changes which have been made till now.
Needs to be done for
Decide on adding / adjusting / ordering test cases to match current problem specs metadata: unsynced: rna-transcription
https://github.com/exercism/php/issues/730