search

exercism / php

Exercism exercises in PHP.
https://exercism.org/tracks/php
MIT License
139 stars 133 forks source link

change: sync binary search #738

Closed fejan-malek closed 1 month ago

fejan-malek commented 1 month ago

Completed all the todos which is mentioned here.

https://github.com/exercism/php/issues/731

Also added 2 new missing test cases from problem_specification.

github-actions[bot] commented 1 month ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

fejan-malek commented 1 month ago

Yes sure I will take "spiral-matrix" as a priority after 2024-06-24!

Till then any issue in priority?

mk-mxp commented 1 month ago

Priority? No, nothing with priority.

We have a list of exercises in issue #684 (at the end, starting with W1 | 2024-01-16 | leap) where syncing is required, but they already were part of the #48in24 challenge. These can be done at any time. I can create issues for each exercise, if you want to do these.

Do you have advanced knowledge of PHP and PHPUnit? There are still some practice exercises missing (see #629). This also requires more knowledge of configlet and the inner workings of Exercism (https://exercism.org/docs/building/tracks/practice-exercises). Before adding one, open a forum discussion in Programming/PHP to discuss which one and how the students interface should look like.

fejan-malek commented 1 month ago

Please wait before doing the next sync task. About 2 weeks before the date in the issue heading is the right time to sync the exercise. Exercism staff updates problem specifications also. So too fast means syncing again.

You told me to wait till 2 weeks correct so I can't contribute to any sync task till that time.

Do you have advanced knowledge of PHP and PHPUnit? There are still some practice exercises missing (see https://github.com/exercism/php/issues/629). This also requires more knowledge of configlet and the inner workings of Exercism

Yes, I am aware of advanced of PHP and even work on frameworks of PHP. And about the PHP unit, I am still getting my hands on it.

So as you suggested me issue is that we have to create a missing exercise is that correct?

fejan-malek commented 1 month ago

If you allow me I can work on re-sync of exercise from W1.