search

exercism / php

Exercism exercises in PHP.
https://exercism.org/tracks/php
MIT License
139 stars 133 forks source link

Sync reverse-string #749

Closed fejan-malek closed 1 month ago

fejan-malek commented 1 month ago

740

also added missing test cases

github-actions[bot] commented 1 month ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

fejan-malek commented 1 month ago

@mk-mxp

Need help

I have added 3 new test cases with the below string and it failed.

子猫
Würstchenstand
ผู้เขียนโปรแกรม

I even tried to update the example code with grapheme_extract and mb_substr but still no success tests.

mk-mxp commented 1 month ago

@fejan92 I'm too busy today. Thanks for your patience!

740

fejan-malek commented 1 month ago

Yeah, no problem.

There is no rush at all.