search

exercism / php

Exercism exercises in PHP.
https://exercism.org/tracks/php
MIT License
139 stars 133 forks source link

Sync Allergies #771

Closed fejan-malek closed 1 week ago

fejan-malek commented 1 week ago

https://github.com/exercism/php/issues/761

We need to update the testdox and uuid comments in the test case.

And this exercise also contains dataprovider test.

github-actions[bot] commented 1 week ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

mk-mxp commented 1 week ago

@fejan-malek I will take a deeper look into this. May take some days to answer.

mk-mxp commented 1 week ago

@fejan-malek I remember doing this exercise, and I struggled heavily with the design of the exercise. And I am not the only one: Track status says, that only 49% finished the exercise. In addition, only 82 persons finished it at all.

So we should not invest more into the current state of the exercise. I will merge the changes you already made. Maybe you want to help re-writing the exercise? See #772

fejan-malek commented 1 week ago

So we should not invest more into the current state of the exercise. I will merge the changes you already made. Maybe you want to help re-writing the exercise? See https://github.com/exercism/php/issues/772

Sure @mk-mxp Will take a look because I never contribute to developing an exercise.