search

exercism / php

Exercism exercises in PHP.
https://exercism.org/tracks/php
MIT License
144 stars 139 forks source link

Commit broken Unit Tests on MacOS but failed silently #859

Closed tomasnorre closed 1 day ago

tomasnorre commented 4 days ago

This commit https://github.com/exercism/php/commit/1df6486b88f85a77387f25fb2d97db8fbf98f967 broken the unit tests on MacOS, but fails silently, so I saw it by coincidence.

Will focus on this before adding more PRs for the Sync Exercises.

Screenshot From 2024-11-14 19-06-06

mk-mxp commented 4 days ago

Maybe add local -a name_filter before name_filter=()? This makes the variable name a) local scoped and b) known as an array even when not filled. If that doesn't help, replace name_filter=() with name_filter=( " " ) # MacOS otherwise sees unbound variable or similar.

tomasnorre commented 4 days ago

Maybe add local -a name_filter before name_filter=()? This makes the variable name a) local scoped and b) known as an array even when not filled. If that doesn't help, replace name_filter=() with name_filter=( " " ) # MacOS otherwise sees unbound variable or similar.

Will check it out later. I have an older macbook, that I might be able to test it on locally.