search

exercism / problem-specifications

Shared metadata for exercism exercises.
MIT License
326 stars 541 forks source link

CI: Immutability check fails on pushes #1728

Open SaschaMann opened 3 years ago

SaschaMann commented 3 years ago

Example build: https://github.com/exercism/problem-specifications/runs/1323686545?check_suite_focus=true

This value needs to be determined differently: https://github.com/exercism/problem-specifications/blob/b889bf897bbd16a40f347d9bdb5f57828dfd3026/.github/workflows/ci.yml#L41

cmccandless commented 3 years ago

Is the check necessary on push?

mohanrajanr commented 3 years ago

@SaschaMann : should we avoid searching for an old commit if we are trying to push a commit to a new branch ? Or handle the checkout of old commit some other way?. I'd like to solve this issue and let me know if I can take this up ?. I still don't understand what should be the right approach to solve this one !. Thanks!.

SaschaMann commented 3 years ago

Is the check necessary on push?

Not sure tbh

I still don't understand what should be the right approach to solve this one

My idea was to compare the previous commit with the last commit. Since pretty much everything is squash-merged, we can somewhat safely assume that this will cover every commit.