search

exercism / problem-specifications

Shared metadata for exercism exercises.
MIT License
326 stars 540 forks source link

Luhn #2150

Open w62 opened 1 year ago

w62 commented 1 year ago

Hi,

I have just completed the exercise Luhn. The instructions are not very clear.

It just mentioned how to process even number digits. It does not mentioned how to process odd number digits. That have made me wondered why 109 failed. Google is here to help. The key idea is the parity. Please update the instruction so that at least it would clearer for the new gophers.

thanks and regards,

william

andrerfcsantos commented 1 year ago

@w62 Move the issue to problem-specifications where the description and tests for practice exercises are discussed. After changes are discussed and approved here, all tracks can benefit from them.

Also, do you have a suggestion on what could be added so the instructions are clearer?

w62 commented 1 year ago

@w62 Move the issue to problem-specifications where the description and tests for practice exercises are discussed. After changes are discussed and approved here, all tracks can benefit from them.

Also, do you have a suggestion on what could be added so the instructions are clearer?

Sorry no. All have done is to add a parity from the google link in my previous link. I am new to Go, and programming, so I might not be able to offer proper formalized improvements. I just shared how I resolved my issue and hope that someone with more Go and programming experiences to review and offer a better problem definition.

andrerfcsantos commented 1 year ago

@w62 That's fine, no worries. Even if you don't feel comfortable suggesting specific improvements, it's always great to hear about your experience and what you found confusing, even if it's then other people working on the actual improvements.

I just shared how I resolved my issue and hope that someone with more Go and programming experiences to review and offer a better problem definition.

That's also why I moved the issue here. People monitoring issues in this repo are used to work on writing good problem specifications, so we got you covered! Since the instructions for the practice problems (like Luhn is) are shared across tracks for different languages, having the issue on Go-specific repositories doesn't give the proper visibility for this issue. Fixing the issue here means that all tracks can then benefit from the improvement in the instructions.