search

exercism / problem-specifications

Shared metadata for exercism exercises.
MIT License
327 stars 542 forks source link

[Secret Handshake] Fix formatting issue in admonition #2286

Closed safwansamsudeen closed 1 year ago

safwansamsudeen commented 1 year ago

There's a note which is looks incorrect in the UI. I think this change will solve it. image

This is a basic PR, so I have not discussed it in the forum beforehand.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

kytrinyx commented 1 year ago

Thanks @safwansamsudeen.

It looks correct to me in the browser on the Ruby track (https://exercism.org/tracks/ruby/exercises/secret-handshake):

Screenshot 2023-06-08 at 1 37 37 PM

Which track are you looking at where it is broken?

safwansamsudeen commented 1 year ago

Python - is this perhaps track specific?

EDIT: perhaps it's because of the instruction append.

A second edit: seems not, because even JS formats it like this.

MatthijsBlom commented 1 year ago

This was fixed in #2238; the fix just hasn't been pulled yet by some tracks.

safwansamsudeen commented 1 year ago

@kytrinyx Upon looking around, it seems both Python and JS lack the blank line between the link text and the link url.

You've committed this only on March 27th - perhaps the tracks haven't synced the change yet?

Sorry for the confusion - I originally opened this in Python, was redirected here, and then failed to see that there was a blank line difference in this version and Python's.

kytrinyx commented 1 year ago

@safwansamsudeen this makes sense. The fix would be to run bin/configlet-fetch in the Python and JS repos, and then bin/configlet sync --update --yes --docs to update any instructions that have fixes from the upstream. --metadata

BethanyG commented 1 year ago

@kytrinyx @safwansamsudeen - my apologies. I had forgotten that this was part of https://github.com/exercism/python/pull/3423, which is on hold by Erik, due to concerns that it would re-queue a bunch of Python solutions for retest unnecessarily.

MatthijsBlom commented 1 year ago

@SleeplessByte I actually expect this PR to break the rendering in just another way. See this forum thread.

SleeplessByte commented 1 year ago

@SleeplessByte I actually expect this PR to break the rendering in just another way. See this forum thread.

Thank you for that. I just rejected this.

I've ran it myself and the old (current) markdown is correct. This PR is invalid.

The problem here was that the GitHub app did NOT show me the closed PR or other messages until after i read your message (via notification).

safwansamsudeen commented 1 year ago

Nice to see this issue understood, thanks to everybody!