search

exercism / problem-specifications

Shared metadata for exercism exercises.
MIT License
327 stars 541 forks source link

Poker: Make high card tests more robust #2336

Closed SLeitgeb closed 11 months ago

SLeitgeb commented 11 months ago

Ensure that high cards are checked in the correct order (high ranking cards down to low ranking cards). Tests previously succeeded even when comparing lowest ranking spare cards first (e.g. "3H JS" beats "2C 5H" even when comparing "3H" vs. "2C").

Two tests added to ensure hands with pairs and triplets of the same rank are checked for high cards down to the last card.

github-actions[bot] commented 11 months ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

IsaacG commented 11 months ago

Is there a forum post to discuss this change? Changes should be discussed on the forum prior to opening a PR.

SLeitgeb commented 11 months ago

I didn't know that, sorry about that. Created a new topic here.

IsaacG commented 11 months ago

Erik says this isn't a problem with existing code. It's been three days without anyone having any concern. I'll click the merge button :smile: