search

exercism / problem-specifications

Shared metadata for exercism exercises.
MIT License
320 stars 539 forks source link

Duplicated test cases in collatz-conjecture/canonical-data.json #2410

Closed rabestro closed 4 months ago

rabestro commented 4 months ago

https://github.com/exercism/problem-specifications/blob/993abcc4e327743a17497dab04f4a03f4f50c2ba/exercises/collatz-conjecture/canonical-data.json#L42

    {
      "uuid": "7d4750e6-def9-4b86-aec7-9f7eb44f95a3",
      "description": "zero is an error",
      "property": "steps",
      "input": {
        "number": 0
      },
      "expected": {
        "error": "Only positive numbers are allowed"
      }
    },
    {
      "uuid": "2187673d-77d6-4543-975e-66df6c50e2da",
      "reimplements": "7d4750e6-def9-4b86-aec7-9f7eb44f95a3",
      "description": "zero is an error",
      "comments": ["Collatz Conjecture holds only for positive integers"],
      "property": "steps",
      "input": {
        "number": 0
      },
      "expected": {
        "error": "Only positive integers are allowed"
      }
    },
    {
      "uuid": "c6c795bf-a288-45e9-86a1-841359ad426d",
      "description": "negative value is an error",
      "property": "steps",
      "input": {
        "number": -15
      },
      "expected": {
        "error": "Only positive numbers are allowed"
      }
    },
    {
      "uuid": "ec11f479-56bc-47fd-a434-bcd7a31a7a2e",
      "reimplements": "c6c795bf-a288-45e9-86a1-841359ad426d",
      "description": "negative value is an error",
      "comments": ["Collatz Conjecture holds only for positive integers"],
      "property": "steps",
      "input": {
        "number": -15
      },
      "expected": {
        "error": "Only positive integers are allowed"
      }
    }
github-actions[bot] commented 4 months ago

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

senekor commented 4 months ago

Existing test cases are never changed, instead a new one is added with the "reimplements" field.

https://github.com/exercism/problem-specifications?tab=readme-ov-file#changing-tests