search

exercism / prolog

Exercism exercises in Prolog.
https://exercism.org/tracks/prolog
MIT License
29 stars 39 forks source link

queen-attack: make X and Y different in diagonal attack/2 tests. #188

Closed marchukov closed 1 year ago

marchukov commented 1 year ago

I have made an error in diagonal condition when doing queen-attack exercise. I wrote "abs(FromX-ToY)" instead of "abs(FromX-ToX)".

This was not catched by the tests, because the choises there are accidentally equial in this regard. Changing From tuple from (2,2) to (2,3) fixes this. I have adjusted To tuples accordingly.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.