qjd2413
commented
6 years ago LGTM. It'd be pretty simple to add an exponent rule/tests, I can add it if you didn't plan to.
Closed mbramson closed 6 years ago
qjd2413
commented
6 years ago LGTM. It'd be pretty simple to add an exponent rule/tests, I can add it if you didn't plan to.
Average-user
commented
6 years ago @qjd2413 or @mbramson We would be happy to see a PR for that. Just make sure is another, and not this one.
Average-user
commented
6 years ago @mbramson Thanks for the PR!
mbramson
commented
6 years ago Yep, I'll get a PR up for that as well.
@parkerl Just a few things that stood out to me after completing this exercise, that could've made this slightly more user friendly.
The real and imaginary tests were located at the bottom of the test file. As these are the simplest functions and can be used in the solutions to the rest of the functions, these functions should be first.
Following convention, there should only be one test that is running the first time that you run the tests.
Fixes a typo in spelling "imaginary" in one of the imaginary tests.
Also of note, the README calls out writing an exponent function for complex numbers, but there are no tests for this (and as a result, no current solutions on exercism actually implemented this function.)