search

exercism / prolog

Exercism exercises in Prolog.
https://exercism.org/tracks/prolog
MIT License
29 stars 39 forks source link

Add wordy to the prolog exercises #96

Closed neenjaw closed 4 years ago

neenjaw commented 5 years ago

This is a series of commits to add wordy to the prolog track. I explored a few new topics to the track to see what interest there is in implementing them more broadly.

Summary of changes:

  1. Added the shebang to the build shell script

    defensive change from differing default shell

  2. Added the '--build` argv flag to the build command

    This is because wordy is coded in the SWI-PL module style, when the test is loaded it imports the wordy module but since it is a stub, if loaded, an error occurs. The --build argv flag prevents the module from being loaded.

  3. added wordy.example, wordy.pl, and wordy_tests.plt for the exercise
  4. added .meta/version for problem specification tracking
  5. added README.md for the problem description
  6. config.json updated and linted with configlet
neenjaw commented 5 years ago

As far as the new topics:

Average-user commented 4 years ago

@neenjaw Thank you. I'm currently looking at it, but as I pointed out in #98 changes to bin/_ should be done in separated PR. If your PR is named add some-exercise to prolog, you should only make commits that create and change files in exercise/some-exercise.

Other than that It seems great. I'll let you know if find anything else. Thank you and apologies for the time passed

neenjaw commented 4 years ago

@Average-user, no problem about time, I completely forgot about this PR. I can separate the PRs, as I don't even recall your other advice for the same.

Thanks for reviewing. Let me know what else I can do before I make that revision.

Average-user commented 4 years ago

Great!, I don't think you should recall anything since it was done in a PR of other person :)

Average-user commented 4 years ago

By the way just in case, if you are interested in becoming maintainer of this track look at #97 . You would be more than welcomed

neenjaw commented 4 years ago

For sure, I will definitely consider it as prolog is very interesting to me. I am working with the elixir track as well on v3, and I think the v3 concept exercises would work really well for learning prolog

Average-user commented 4 years ago

@neenjaw Apart from moving the commit on bin to other PR, the only thing I would suggest is setting difficulty to 1. Of course this exercises is not of difficulty 1, but as for now all exercises are set to that. And a PR to fix all of them should be done separately. Or at least that was de conclusion at which we arrived in some conversation in slack that I currently can't find. But let me know what you think about that

neenjaw commented 4 years ago

That sounds fair! I'll try get these revisions written up and opened today or tomorrow. Thanks for the review!

neenjaw commented 4 years ago

This build will fail because fetch-configlet needs to be updated. See elixir's PR for more information here: https://github.com/exercism/elixir/pull/535

If you agree, I think this could be merged and a followup PR opened to update the configlet.

neenjaw commented 4 years ago

I have also removed the swi-pl module concept from this exercise so that the script at bin/build.sh does not need to be updated.

Average-user commented 4 years ago

Wouldn't it be smoother if we first merge the PR for fetch-configlet? I'm not sure, but I think tat would make the tests pass automatically. I remember doing it like this in exercisms haskell repo. But that was long ago.

neenjaw commented 4 years ago

Sounds good, see #99, I will rebase this before merge.

Average-user commented 4 years ago

@neenjaw Mhh apparently not working as I thought. I'm looking at if I can find a way to make travis rerun the tests

Average-user commented 4 years ago

@neenjaw Well thankyou now It seems we are good to go! I'll wait your confirmation before merge

neenjaw commented 4 years ago

I am good if you are! :)