exercism / purescript

Exercism exercises in PureScript.
https://exercism.org/tracks/purescript
MIT License
37 stars 32 forks source link

Update pangram test to remove non-ASCII characters, closes #53 #218

Closed icyrockcom closed 3 years ago

SleeplessByte commented 3 years ago

I haven't checked but if this mimics a test from the canonical data (https://github.com/exercism/problem-specifications/blob/f375051787370bd1af1dd84e8d6c116f07d88ad2/exercises/pangram/canonical-data.json), then the tests.toml file should be updated to: https://github.com/exercism/purescript/blob/3d0913a2f4463adeb85c4c7847eb2e0f510c1038/exercises/practice/pangram/.meta/tests.toml.

Can you confirm it's either not necessary (because it doesn't exist in the canonical data) or update it, either manually, or by using configlet?

icyrockcom commented 3 years ago

@SleeplessByte This particular test is already there:

https://github.com/exercism/problem-specifications/blob/main/exercises/pangram/canonical-data.json#L90

https://github.com/exercism/purescript/blob/3d0913a2f4463adeb85c4c7847eb2e0f510c1038/exercises/practice/pangram/.meta/tests.toml#L39

icyrockcom commented 3 years ago

The descriptions do not match though and there's one more test in the problem set:

    test "sentence empty" do
    test "pangram with only lower case" do
    test "missing character 'x'" do
    test "another missing character 'x'" do
    test "pangram with underscores" do
    test "pangram with numbers" do
    test "missing letters replaced by numbers" do
    test "pangram with mixed case and punctuation" do
    test "upper and lower case versions of the same character should not be counted separately" do

vs

# - Recreate every `description` key/value pair
description = "empty sentence"
description = "perfect lower case"
description = "only lower case"
description = "missing the letter 'x'"
description = "missing the letter 'h'"
description = "with underscores"
description = "with numbers"
description = "missing letters replaced by numbers"
description = "mixed case and punctuation"
description = "case insensitive"

Do you want me to update that before you merge?

SleeplessByte commented 3 years ago

That would be grand if you could!

icyrockcom commented 3 years ago

@SleeplessByte Done, let me know how it looks.

SleeplessByte commented 3 years ago

Your change will be live in a few minutes on https://exercism.org/. Sign up with GitHub if you don't have an account yet!