search

exercism / python-representer

GNU Affero General Public License v3.0
6 stars 9 forks source link

Add tests for dataclasses that use Slots and Keyword-Only options. #56

Open brocla opened 8 months ago

brocla commented 8 months ago

A test is added to verify that the new dataclass features, slots and kw_only, can be parsed by the Representer.

The three examples used are: sgf_parsing, go_counting, and tree_building. They were chosen because their solutions already use dataclasses, making it easier to demonstrate the new features.

github-actions[bot] commented 8 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

brocla commented 7 months ago

The test is failing on this PR because of code like this,

@dataclass(slots=True)   #***
class Record:
    record_id: int
    parent_id: int = field(kw_only=True)

Perhaps I don't have access to the latest update that fixed this issue. I'm a bit stuck.

BethanyG commented 7 months ago

I'll take a look.