Closed BethanyG closed 3 years ago
This issue has been automatically marked as abandoned 🏚
because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as abandoned 🏚
because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Is this task still unfinished?
Hi @mukeshgurpude 👋🏽 This task is indeed unfinished. I was in the middle of it when we went to launch, so I have a half finished PR. I'd love some help, if you'd like to join in? Just let me know, and I can flag it as [claimed] for you.
I would like to help on this task. I would start working on this task later in the day. Could you please update the links about Markdown style guides in Issue description, they are giving me 404 now🤔.
The task is all yours! And thank you for taking it on! 🌟
I am going to go ahead and PR what I have and flag it as a draft. You should then be able to make commits to it. Or not. Your choice! You can also start over from the top, if you prefer. 😄
Could you please update the links about Markdown style guides in Issue description, they are giving me 404 now🤔.
Yes. Apologies! All the links should now be updated to go to the nicely formatted website docs. LMK if you have additional questions or issues. I should be available until midnight pacific.
The draft PR is here: https://github.com/exercism/python/pull/2530
Hello @BethanyG. Since there is already a pull request from your fork to the upstream, I thought of pushing changes to your fork only.. I've opened a pull request https://github.com/BethanyG/python/pull/15, but maybe you missed it by chance..
@mukeshgurpude -- Oh no! I *did miss it! 😱 so sorry. I will take a look right now. Thanks!
@BethanyG as related PR is merged, we should close this issue now.
@mukeshgurpude -- thank you for the reminder! 😂 I have one too many things to do, and forgot this.
This issue is for improvements & changes needed to the
inventory-management
concept exercise on the Python track.Goals
Improve the Inventory-management (
dicts
) concept exercise by adding thedict.pop()
method & creation viadict literal
to the tasks the student has to complete. Make other improvement changes as noted below:design.md
doc to adddict.pop()
to the designIntroduction.md
to adddict.pop()
usage.instructions.md
to add new tasks:dict
literalsdict.pop()
hints.md
fordict.pop()
usageexemplar.py
to include new idiomatic solution for newly added tasksdicts_test.py
file to add new tests fordict.pop()
task.dicts.py
stub file to add new tasks.import *
Getting started
Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents: