Closed joMarsch closed 2 years ago
🤖 🤖
Hi! 👋🏽 👋 Welcome to the Exercism Python Repo!
Thank you for opening an issue! 🐍 🌈 ✨
◦ If you'd also like to make a PR to fix the issue, please have a quick look at the Pull Requests doc.
We 💙 PRs that follow our Exercism & Track contributing guidelines!
Please feel free to submit a PR, linking to this issue.
🎉
‼️ Please Do Not ‼️ ❗ Run checks on the whole repo & submit a bunch of PRs. This creates longer review cycles & exhausts reviewers energy & time. It may also conflict with ongoing changes from other contributors. ❗ Insert only blank lines, make a closing bracket drop to the next line, change a word to a synonym without obvious reason, or add trailing space that's not an[ EOL][EOL] for the very end of text files. ❗ Introduce arbitrary changes "just to change things" . _...These sorts of things are **not** considered helpful, and will likely be closed by reviewers._ |
💛 💙 While you are here... If you decide to help out with other open issues, you have our gratitude 🙌 🙌🏽.
Anything tagged with [help wanted]
and without [Claimed]
is up for grabs.
Comment on the issue and we will reserve it for you. 🌈 ✨
Hi @joMarsch 👋🏽
Thanks for filing this issue. The Python track pulls test data (inputs and expected results) from a central repo, problem specifications, where the canonical data shows that [1,2,1]
is indeed the expected result for the case.
I would recommend that you either open an issue in that repo to discuss things, or open a discussion on our discussion forum to talk through the exercise and the test results, and where you think they should be changed or improved.
Once we get an understanding of what should be changed in problem specifications, all repos that pull from there can be updated with the information.
For anyone who might have encountered the same confusion - I searched for the forth documentation and realised what the OVER
command actually does is:
OVER ( n1 n2 — n1 n2 n1 ) Copies second item to top
Hence the test is actually correct.
Link: https://www.forth.com/starting-forth/2-stack-manipulation-operators-arithmetic/
Test 29 of the Forth exercise seems wrong. If I understand the test the right way the output should be [1,2,2] instead of [1,2,1].