search

exercism / python

Exercism exercises in Python.
https://exercism.org/tracks/python
MIT License
1.9k stars 1.27k forks source link

Insufficient test cases for "Resistor Color Expert" #3795

Open xanni opened 1 day ago

xanni commented 1 day ago

I submitted code that passed all the existing tests but failed to correctly handle some actual resistor values in use in the E48 (2% tolerance) and larger series. There are currently no tests for 5-band resistors where the second band is black, which my earlier iteration handled wrongly.

github-actions[bot] commented 1 day ago

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

BethanyG commented 17 hours ago

Linking forum discussion.

Happy to accept suggested test cases and/or PR. 😄

xanni commented 4 hours ago

PR created: https://github.com/exercism/python/pull/3797