Insufficient test cases in `house`

[armahillo]

Currently there is a single example in house that only requires a class method, :recite and that it dumps the full text of the rhyme. But this can technically be satisfied by doing a HEREDOC that outputs the prescribed text.

I was looking at the practice module and considered adding more tests, but I was unclear on what the intention was for this module.

Some possible outcomes I think could be tested for (based on what I believe this exercise is meant to teach):

• lines can be added to a collection and as they are added, it recites back the cumulative lines that have been collected so far
• the usage of class instance variables (if the lines are added to the class instance)
• the usage of dependency injection (if the .recite method instead receives an enumerable object, it will enumerate the object and output each iteration to a string)
• modal rendering of lines depending on their placement (Sandi Metz did something similar with 99 Bottles): line one begins with "This is the {noun}", subsequent lines begin with "that {verb} the {noun}"
• requiring flexibility in rendering so that giving the lines in a different order (use a shuffled array to seed it) it still renders predictably.
• the use of the << operator (if using an instance of House to store lines)
• the use of Enumerable (if using an instance of House to store lines)
• the use of a splat operator as an argument to .recite if a class-oriented approach is preferred.

Most of the exercises don't tend to coerce the creation of support objects, that's just something the user is meant to figure out on their own, but maybe this exercise could be a little more heavy-handed about that, because it seems like a good opportunity to do that?

All that is to say -- I think this is a potentially useful exercise that can be fun to work with and teach some cool stuff, but currently the tests do not provide the typical useful guidance found in most other exercises.

[github-actions[bot]]

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.