get dockerfile working as intended

exercism / rust-test-runner

GNU Affero General Public License v3.0

3 stars 15 forks source link

get dockerfile working as intended #1

Closed coriolinus closed 5 years ago

coriolinus commented 5 years ago

@exercism/ops I committed the first draft of Dockerfile before noticing that I was supposed to PR these changes through you; this PR should stand in both for its own work and the rest of the file. I'm still committing to master while trying to stand up the MVP, but I think this file at least is ready for review.

iHiD commented 5 years ago

@coriolinus Thanks :)

I've given @exercism/ops write permissions on here, and they can now be assigned to PRs (which I've done too).

iHiD commented 5 years ago

@coriolinus As a sidenote, I'm happy for you to get to an MVP without feeling the need for review, then a final review can happen at deploy, and any changes then beyond that.

coriolinus commented 5 years ago

@iHiD sounds good! In that case, I'm going to merge both of the open PRs now, pending review at deploy. I've just completed basic MVP work, though there are still several TODOs listed in https://github.com/exercism/rust-test-runner/pull/2/commits/d1c3fd234d78cbd56195236647e332bc37fe2064.