search

exercism / rust

Exercism exercises in Rust.
https://exercism.org/tracks/rust
MIT License
1.46k stars 519 forks source link

Affine Cipher problem description is incomplete #1496

Closed asarkar closed 10 months ago

asarkar commented 2 years ago

The problem statement states m=26, but the tests use upper and lowercase letter, whitespace, punctuations, and numbers. Last I checked, all those didn't fit in the lower case ASCII alphabet range of a..z.

coriolinus commented 2 years ago

From the instructions:

Ciphertext is written out in groups of fixed length, the traditional group size being 5 letters, and punctuation is excluded.

It is true that the instructions do not mention that digits should be passed through unchanged and capitals should be lowercased. I believe that these facts are obvious given the context in which they are tested, but it rarely hurts to make the documentation more explicit.

asarkar commented 2 years ago

@coriolinus so, is the following correct? lowercase => convert using equation uppercase => convert to lowercase and use rule 1 white space => ignore punctuation => ignore digits => pass through

coriolinus commented 2 years ago

White space and punctuation are stripped out. Otherwise, yes.

AryanGodara commented 1 year ago

Can I open a PR to work on this Issue? I am relatively new to Rust, but I have good experience in open-source, and want to contribute to exercism.

coriolinus commented 1 year ago

Yes the team always appreciates pull requests.

On Thu, Feb 23, 2023, 18:53 Aryan Godara @.***> wrote:

Can I open a PR to work on this Issue? I am relatively new to Rust, but I have good experience in open-source, and want to contribute to exercism.

— Reply to this email directly, view it on GitHub https://github.com/exercism/rust/issues/1496#issuecomment-1442194553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3V4TRLXXOJ6ZCDP6GF6HLWY6PYLANCNFSM5XMULCOQ . You are receiving this because you were mentioned.Message ID: @.***>

senekor commented 10 months ago

I synced this exercise with problem-specifications a couple months ago and the instructions now include the following:

For the purpose of this exercise, digits are valid input but they are not encrypted. Spaces and punctuation characters are excluded.

If this can / shoud still be improved, it would be best to take the discussion to the problem-specifications repository.