search

exercism / rust

Exercism exercises in Rust.
https://exercism.org/tracks/rust
MIT License
1.41k stars 517 forks source link

protein-translation: adds extra codons without mentioning them in instructions #1936

Open ErikSchierboom opened 3 days ago

ErikSchierboom commented 3 days ago

The protein-translation exercise adds extra codons without mentioning them in the instructions. This makes it confusing for students. I would personally be in favor of dropping the additional codons that are not mentioned in the instructions, instead of extending the instructions, as the extra codons don't really help teach anything.

senekor commented 3 days ago

What about it is confusing to students? The list of codons needed for the tests is passed to the parse function. If they use that correctly, they won't ever notice that the list is extended. They would only notice if they hardcode the list, which I wouldn't want to encourage.

It would make more sense to me to extend the instructions and tests in problem-specifications to cover all codons. I remember we had an issue where there was even a test that prevented the full list of codons from being implemented. (forum thread) That wouldn't have happended if we just included all valid codons in the test suite.