search

exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Added missing case that is in tests, but not here #565

Closed Algiras closed 6 years ago

Algiras commented 6 years ago

https://github.com/exercism/scala/blob/master/exercises/bob/src/test/scala/BobTest.scala#L48

ErikSchierboom commented 6 years ago

Hi @Algiras. First of all, thanks for the PR! It's really appreciated. However, this PR directly modifies the test file, whereas most exercises' test suites in the Scala track are automatically being generated. You can find the generator for the Bob exercise here: https://github.com/exercism/scala/blob/master/testgen/src/main/scala/BobTestGenerator.scala

So to update the test suite, what needs to be done is to:

  1. Run the test generator for the Bob exercise (@ricemery will know how to do that).
  2. Verify that the existing example implementation still passes all the tests.
ricemery commented 6 years ago

@ErikSchierboom it looks like @Algiras just changed the readme. And, linked to the previous code change in the test code. This change looks fine to me. I am going to go ahead and merge it.

Thanks @ErikSchierboom and @Algiras .