exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Update Allergies to match latest test data. Refs #488 #594

Closed ricemery closed 5 years ago

ricemery commented 5 years ago

Oops. I'll run this back through scalafmt.

Thanks for reviewing/merging all of the pull requests.

On Tue, Jan 1, 2019 at 5:59 AM Erik Schierboom notifications@github.com wrote:

@ErikSchierboom commented on this pull request.

In exercises/allergies/src/test/scala/AllergiesTest.scala https://github.com/exercism/scala/pull/594#discussion_r244636803:

}

test("ignore non allergen score parts") { pending

  • Allergies.list(509) should be(
  • List(Allergen.Eggs,
  • Allergen.Shellfish,
  • Allergen.Strawberries,
  • Allergen.Tomatoes,
  • Allergen.Chocolate,
  • Allergen.Pollen,
  • Allergen.Cats))
  • Allergies.list(509) should be (List(Allergen.Eggs, Allergen.Shellfish, Allergen.Strawberries, Allergen.Tomatoes, Allergen.Chocolate, Allergen.Pollen, Allergen.Cats))

The previous version was a bit more readable, but I assume this is just default behavior of the test generator?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/exercism/scala/pull/594#pullrequestreview-188556200, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeHG14_S0z72_stQxVtx4IPOMQSCBaeks5u-1umgaJpZM4Zlroc .

ErikSchierboom commented 5 years ago

Great!