exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Security Issue - .gitignore file needs updated to remove files with personal information #710

Closed brownbonnie closed 2 years ago

brownbonnie commented 2 years ago

Since SBT version 1.4.9. there is now an auto-generated /.bsp/sbt.json file which contains personal information, including the developer's username and folder structures. This project is using SBT 1.5.2 so the issue is occurring, and because this is a public repository this is a security issue.

There are also auto-generated project files which contain this same information, and these need to be added to the .gitignore file also.

For the Two-Fer exercise specifically, these files need to be added to the .gitignore file; but this will need implemented project wide also:

For more information see: https://www.scala-lang.org/blog/2020/10/27/bsp-in-sbt.html

ErikSchierboom commented 2 years ago

Good catch. Would you be willing to submit a PR to fix this?

brownbonnie commented 2 years ago

PR raised for this, thanks: https://github.com/exercism/scala/pull/711

ErikSchierboom commented 2 years ago

Closed by #711