search

exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Security Patch: Updated .gitignore file to include auto-generated files which include personal information #711

Closed brownbonnie closed 2 years ago

brownbonnie commented 2 years ago

Since SBT version 1.4.9. there is now an auto-generated /.bsp/sbt.json file which contains personal information, including the developer's username and folder structures. This project is using SBT 1.5.2 so the issue is occurring, and because this is a public repository this is a security issue, which this PR is being raised to fix.

There are also auto-generated project files which contain this same information, and these have been added to the .gitignore file also.

For the Two-Fer exercise specifically the following files needed adding to the .gitignore file:

However, this fix has been applied at the root/ top level of the project, so works for every exercise.

All the aforementioned files are generated when the project is compiled or the unit tests are ran using SBT.

For more information see: https://www.scala-lang.org/blog/2020/10/27/bsp-in-sbt.html

brownbonnie commented 2 years ago

Looks like the linter has failed at the following: The value of exercises.practice.difficulty is 0, but it must be between 1 and 10 (inclusive): /home/runner/work/scala/scala/config.json

I think this is a separate issue?

ErikSchierboom commented 2 years ago

That is indeed a separate issue.