search

exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Bump Scala to version `2.13` and scalatest to version `3.2.10` #712

Closed CJSmith-0141 closed 2 years ago

CJSmith-0141 commented 2 years ago

Addresses #678 and partially addresses #684

I also ran configlet sync -u, not sure if that was needed or necessary.

I was not able to get the generation code to work, could someone help bring that home? It might need a re-write.

Help needed on the test generation. Manually editing the tests with these changes works.

CJSmith-0141 commented 2 years ago

looking at the maintainer tracker found here I'm going to assume that @ErikSchierboom or @iHiD could potentially help me complete this PR or point me in the right direction.

ErikSchierboom commented 2 years ago

Thanks a lot!

I also ran configlet sync -u, not sure if that was needed or necessary.

I don't think that was necessary. In fact, could you perhaps remove that commit from this PR and open a separate PR for the syncing update? The update is much appreciated, but we prefer to have PRs do just a single thing.

I was not able to get the generation code to work, could someone help bring that home? It might need a re-write.

We currently don't have any active Scala maintainers. What I would do is to just ignore the generators now and only update the exercises.

CJSmith-0141 commented 2 years ago

I removed the configlet sync -u commit and added a commit that manually updates the org.scalatest imports and class traits for the exercise tests.

I think another PR to update track requirements in the documentation might be needed, or that might be in scope for this PR. Let me know.

ErikSchierboom commented 2 years ago

I removed the configlet sync -u commit and added a commit that manually updates the org.scalatest imports and class traits for the exercise tests.

Perfect.

I think another PR to update track requirements in the documentation might be needed, or that might be in scope for this PR. Let me know.

Yes, I think it makes sense to include it in this PR, as it is a related change.

CJSmith-0141 commented 2 years ago

No worries, added my two cents to docs/INSTALLATION.md

ErikSchierboom commented 2 years ago

Merged! Thanks a lot.

ErikSchierboom commented 2 years ago

@CJSmith-0141 BTW, did you intend to try and upgrade to Scala 3 too?

CJSmith-0141 commented 2 years ago

For my day job we're waiting for some of the more of the libraries we use to update to Scala 3 before we make the plunge.

That being said, if Exercism's appetite is to stay cutting edge I would be happy to take a crack at it.

ErikSchierboom commented 2 years ago

Well, we don't really use many libraries. I guess we could maybe do an inventory of the libraries we use, but I expect it's very limited. So yes: I think trying to upgrade to Scala 3 makes sense for us!