search

exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Improve instructions and fix tests for PyhagoreanTriplet exercise. #731

Closed LarsWestergren closed 2 years ago

LarsWestergren commented 2 years ago

Fixes https://github.com/exercism/scala/issues/636

LarsWestergren commented 2 years ago

Ready for a new review, sorry for all the commits.

After checking several other languages (Go, Java, F#, Ruby, Haskell) they all have tests for the method/function the problem mainly discusses - "Given an input integer N, find all Pythagorean triplets", so I added tests and an implementation for that. Having it makes it clearer what the other methods do, so instructions shouldn't need changing.

Removed the automatic sorting of inputs in .meta/Example.scala.

Should I squash all the commits into one?

ErikSchierboom commented 2 years ago

@LarsWestergren CI is failing. It looks to be related to the changes in this PR. Could you look into it?

LarsWestergren commented 2 years ago

@LarsWestergren CI is failing. It looks to be related to the changes in this PR. Could you look into it?

Embarassing, missed comitting my last change. Fixed now, and also used configlet to sync the docs.

ErikSchierboom commented 2 years ago

Merged! Thanks 🎉