search

exercism / scala

Exercism exercises in Scala.
https://exercism.org/tracks/scala
MIT License
123 stars 131 forks source link

Update binary search function signature & add scaffold #750

Closed wg-romank closed 1 year ago

wg-romank commented 1 year ago

Hi folks,

First of all thanks a lot for putting this together, I found this platform by #12in23 challenge that started recently.

I'm submitting a minor suggestion on Binary Search problem expected signature + adding scaffold code so user can have a quick start (not sure if reading tests and deducing signature was intended).

Main change is from List to Array, since Array has memory adjacency and guarantees O(1) [1] indexing while List is a linked list so using it for binary search lookups is less efficient. Array however is a mutable data structure so ArraySeq could also be used if enforcing immutability is required. Please let me know and I'll adjust the change.

Thanks!

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.