search

exercism / sed

Exercism exercises in sed.
https://exercism.org/tracks/sed
MIT License
1 stars 2 forks source link

CI failure #11

Closed glennj closed 1 month ago

glennj commented 1 month ago

@jimmytty are you keeping your eye on CI failures?

https://github.com/exercism/sed/commit/6a42da1e97874f33bb684bc596a8c3dc2290c903 https://github.com/exercism/sed/actions/runs/9915553748/job/27396578539

jimmytty commented 1 month ago

I was ignoring them until now. I stopped doing new exercises (more coming soon) and now I'm going to take a look at CI integration. (https://exercism.org/docs/building/tracks/new/setup-continuous-integration). It seems like an "easy job" (I hope), so I'll resolve the issue in the next few hours.

glennj commented 1 month ago

Fixing the problems listed in my 2nd link would be a good start.

jimmytty commented 1 month ago

Sorry @glennj! I misunderstood the problems thinking they were about "Setup Continuous Integration". I'm trying to follow step-by-step the first opened issue Launch tracking #1 and the linting problems are one step ahead of "Setup Continuous Integration". I finally started to use ./bin/verify-exercises (very basic) and ./bin/configlet lint and already committed the the fixes. Anyway, I'm still looking at the documentation and I'll continue to improve the configuration.

Thank you for your observations.

glennj commented 1 month ago

Good old communication... I could have been more clear as you are new to this infrastructure. By "CI" I meant the github workflows configured in https://github.com/exercism/sed/tree/main/.github/workflows

The configlet workflow runs for every commit to main, so filling the missing parts of config.json can be a top priority.

I'll create a issue for it and assign it to myself.

glennj commented 1 month ago

Also, speaking of communication, where would you prefer to talk about the sed track? In PRs and issues here, on the exercism forum, on discord?

jimmytty commented 1 month ago

Also, speaking of communication, where would you prefer to talk about the sed track? In PRs and issues here, on the exercism forum, on discord?

I don't know the best way to discuss sed track and I welcome suggestions. I prefer to use the same "workflow" as you all.

For example, IMHO, Github is good for discussing repository issues, while the exercise forum is good for open discussions and ideas and is more formal and restricted than discord. Maybe a mix of them all can be the best approach, but I'm new and it's easy to me to make a mess.

glennj commented 1 month ago

I was just checking to see if you have any strong preferences. I agree that github is the place to discuss specifics, and the forum to discuss bigger topics.

glennj commented 1 month ago

The original reason for this issue has been resolved.