search

exercism / sml

Exercism exercises in Standard ML.
https://exercism.org/tracks/sml
MIT License
26 stars 34 forks source link

Remove negation #198

Closed Munksgaard closed 2 years ago

Munksgaard commented 2 years ago

I believe the wording doesn't make sense with this negation.

Munksgaard commented 2 years ago

Actually, looking at the tests, I think I'm supposed to return NONE if the input is less than one?

rainij commented 2 years ago

@Munksgaard I agree to your observations: the wording should be corrected as you suggested and moreover the comment about raising Domain is not consistent with what the tests do. Probably it is easiest to just adjust the description to match the tests.

Maybe you can adjust the wording one more time and then ask one of the maintainers (I am not one of them)? See the other PRs for whom to ping.

Munksgaard commented 2 years ago

Good idea @rainij. I have added an additional commit to suggest using NONE instead of raising an exception on invalid input.

@ErikSchierboom, I see you've approved some other PRs, would you care to take a look at this one or point me in the direction of the person who can?

rainij commented 2 years ago

@kotp @ErikSchierboom this PR could probably merged too.

ErikSchierboom commented 2 years ago

Done 🎉