search

exercism / sml

Exercism exercises in Standard ML.
https://exercism.org/tracks/sml
MIT License
27 stars 35 forks source link

Remove bad makefile target gha #199

Closed rainij closed 2 years ago

rainij commented 2 years ago

I simplified the test-setup in the spirit of issue https://github.com/exercism/sml/issues/196. I did the following:

  1. Remove makefile target gha and the related target debug.
  2. Merge workflows ci.yml and ci-pull-request.yml into one file (ci.yml).
  3. Using make test to execute all tests in ci.yml.
  4. Corrected the test for exercise "binary" (I executed ./bin/generate --test-only binary) since it was (silently) failing.

I did (1) and (3) because, as discussed in the issue, the current setup is already so complicated that tests started to fail silently. Moreover, the debug target did not completely take into account that the default target isn't master anymore. I did (2) to avoid code duplication. That the failing test in (4) wasn't discovered before, shows that (3) is a good move (in my opinion).

rainij commented 2 years ago

One remark: The test in (4) still failed silently (look into the ci-run after my second commit). The scope of my PR is not to solve this, but I added a comment to this issue https://github.com/exercism/sml/issues/134.

ErikSchierboom commented 2 years ago

Merged. Thanks a lot! 🎉