search

exercism / swift

Exercism exercises in Swift.
https://exercism.org/tracks/swift
MIT License
113 stars 158 forks source link

bit checking order is reversed in tests #578

Closed BaseCase closed 2 years ago

BaseCase commented 2 years ago

I believe the tests for this exercise are written expecting we check the bits from right to left, not left to right as indicated here. testShuffle1 and testShuffle3 both pass regardless of which direction we go, but testShuffle2 fails when going left to right.

If starting with leftmost is the correct behavior, then I believe testShuffle2 should expect to get ("Purple", "Marigold", "Cyan") instead of the ("Marigold", "Cyan", "Purple") it currently wants (I could do a different PR with that change instead of this if that's the right thing).

I might also just be confused and it's correct as is!!

ErikSchierboom commented 2 years ago

Pinging @exercism/reviewers

paiv commented 2 years ago

Linking

BaseCase commented 2 years ago

Ah! My mistake, I failed to check existing PRs before opening this one. Apologies for the noise. @paiv, would you like me to close this?

kotp commented 2 years ago

This is an identical proposal as #497 and so I am closing as a duplicate. A discussion is availble in issue #496.