search

exercism / swift

Exercism exercises in Swift.
https://exercism.org/tracks/swift
MIT License
113 stars 158 forks source link

Fix largest-series-products tests #623

Closed kytrinyx closed 1 year ago

kytrinyx commented 1 year ago

We deleted a couple of tests from the test suite but they were still being referenced from allTests.

This deletes the stray references.

meatball133 commented 1 year ago

I think the old test runner had a reference to the allTests. But the new one removed that reference, so that constant is not really needed, so it could be omitted.

kytrinyx commented 1 year ago

That would explain why CI passed 😅

kytrinyx commented 1 year ago

@meatball133 Is allTests just a concept exercises thing? There are a bunch of these constants everywhere.

meatball133 commented 1 year ago

I will be honest, I am not sure. But I think there were some kind of requirement to have it since swift couldn't find tests by itself and then Apple made so you didn't anymore, I think this pr added it for linux: https://github.com/apple/swift-package-manager/pull/2174

Here can you see one of apples repo updating its tests files: https://github.com/apple/swift-syntax/pull/171/files

kytrinyx commented 1 year ago

So... maybe we can remove them everywhere. I will make a PR and we can see what happens.

meatball133 commented 1 year ago

Concept exercises have 2 additional files. I have removed those files and the alltest from the test runner and the exercise still works. But removing testAll without removing those 2 files will create errors.

But yes I think we could try to remove them.