search

exercism / swift

Exercism exercises in Swift.
https://exercism.org/tracks/swift
MIT License
113 stars 158 forks source link

Remove allTests constant in practice exercises #631

Closed kytrinyx closed 1 year ago

kytrinyx commented 1 year ago

Apple appears to have changed things so that you no longer have to explicitly tell the test runner which tests exist.

This removes the explicitly defined allTests constant from the practice exercises.

~Note that I'm not actually sure this will work—I'm making the PR so that we can see if CI passes.~ Edit: seems like it's working...

kytrinyx commented 1 year ago

Let me know what you all think. If this looks good I can try doing the same thing for the concept exercises.

kytrinyx commented 1 year ago

Yes, it would definitely cause everything to be re-run. Let's wait for @ErikSchierboom to weigh in on that. We may want to wait to merge to make sure there isn't anything else going on at the same time.

ErikSchierboom commented 1 year ago

I think it looks good, and it should work.

Is there a corresponding test runner PR that verifies this? As in: a PR that updates the golden tests?

ErikSchierboom commented 1 year ago

Yes, it would definitely cause everything to be re-run.

We'll be working on something to bypass this (not having to run everything).

meatball133 commented 1 year ago

Is there a corresponding test runner PR that verifies this? As in: a PR that updates the golden tests?

I could start writing one, but I have done testing which points at that there shouldn't be any problems, both on the test runner and my local machine.

meatball133 commented 1 year ago

https://github.com/exercism/swift-test-runner/pull/47

ErikSchierboom commented 1 year ago

That's great. I would propose to wait merging this until we have the "ignore test runs" feature deployed