search

exercism / swift

Exercism exercises in Swift.
https://exercism.org/tracks/swift
MIT License
113 stars 158 forks source link

Fix typo in high-score board instructions #752

Closed spaenleh closed 4 months ago

spaenleh commented 4 months ago

In this PR I propose to fix a small typo in the high-score board instructions file.

Let me know if you would prefer to group this fix with other fixes. I haven't spotted others so far. I see that https://github.com/exercism/swift/pull/725 is still open, so maybe they can be grouped.

meatball133 commented 4 months ago

I think it is okay to not group this pr with 725, I will let the contributor get some more time to make the changes I said had to be made.

Meanwhile these changes should also be applied to the following files:

Otherwise, the changes look good!

spaenleh commented 4 months ago

@meatball133 Thank you for your comment, I looked at the files you mentioned but did not see any change needed there. Let me know if I missed some, or if you wanted me to check files related to the same concept.

I used the opportunity to cleanup the concepts:dictionaries:about.md file by removing some dangling code fences and adding a missing code example (copied from another file).

Can you review these changes, or should I wait for another maintainer to comment on the PR ? Thank you again for your time.

meatball133 commented 4 months ago

I took a very and I mean very hasty look at the pr and didnt check the underlying docs. But realized quickly after I took another look rn after your comment that the docs are incorrectly structured (not anything you have done or could have known). The about file should always be longer than the introduction file and often to keep things simple it is often quite good to keep those files rather similiar. Seems like the author of this concept didnt do any of that.

So I will approve your pr and merge it and put this on my list to reorginze the docs.