exercism / typescript-test-runner

GNU Affero General Public License v3.0
1 stars 4 forks source link

console.log problem in editor #28

Closed junedev closed 2 years ago

junedev commented 2 years ago

From the editor bug reports:

Hello, I am unable to use the console.log() function to perform debugging. When I add the line, it always says {Try changing the 'lib' compiler option to include 'dom'}. Would request you to kindly look into it

James-N-M commented 2 years ago

I'd like to pick this one up, can anybody offer me some guidance ?

SleeplessByte commented 2 years ago

Hi @James-N-M ! Yes you may. The issue is likely here in run.sh. Copying the types also doesn't work, because we had to disable the tests in order to make this work (describe and it could not be found).

I didn't have time to investigate. It's very likely that all we need is "just" change tsconfig.json in the input directory to resolve this, and make sure that that tsc call picks up that tsconfig.json.

Find the interface for the test runner at https://exercism.org/docs/building/tooling/test-runners/interface, to help you understand how it's ran.

James-N-M commented 2 years ago

Thanks for the info @SleeplessByte !

James-N-M commented 2 years ago

Not sure if anyone else is getting this issue when running the file, I'm not sure if its my node version or yarn version.

node: v12.19.0 yarn: 1.22.10

Screen Shot 2021-10-09 at 11 45 58 AM
James-N-M commented 2 years ago

I think the bash script might be wrong, I'm going to look at other test runners to see if I can spot differences. New to Bash scripting but I'm happy to learn :)

SleeplessByte commented 2 years ago

Possible that it's actually not bourne-compatible and thus bash specific. It should just be https only though, so you can remove the ?( and ) and retry.

SleeplessByte commented 2 years ago

Let's wait for https://github.com/exercism/typescript-test-runner/actions/runs/1330372092 to pass and then can you try it out @James-N-M ?

SleeplessByte commented 2 years ago

Should have been resolved