Update tsconfig.json - Githubissues

exercism / typescript-test-runner

GNU Affero General Public License v3.0

1 stars 4 forks source link

Update tsconfig.json #34

Closed James-N-M closed 2 years ago

James-N-M commented 2 years ago

Issue [(https://github.com/exercism/typescript-test-runner/issues/28)]

Updating tsconfig.json to allow users to use console.log() in the editor window to debug solutions.

SleeplessByte commented 2 years ago

Does this solve the error, or we don't know?

SleeplessByte commented 2 years ago

/format

github-actions[bot] commented 2 years ago

The "Format code" action has started running.

github-actions[bot] commented 2 years ago

The "Format code" action has finished running.

github-actions[bot] commented 2 years ago

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
Close and reopen the PR.
Push a regular commit to this branch.

James-N-M commented 2 years ago

I didn't get to test it properly, I may need some help running the project.

SleeplessByte commented 2 years ago

Can you attempt to fix the CI by removing src/declarations.d.ts? (the one with type Window = undefined)

SleeplessByte commented 2 years ago

The quickest way to test is probably:

get the checks green
have me merge it
wait ~2-10 minutes for it to deploy
try it on the live site :D

James-N-M commented 2 years ago

Do you want me to delete the file src/declarations.d.ts ?? then commit that change, also can you add the hacktoberfest-accepted label to this pr :)