exercism / typescript

Exercism exercises in TypeScript.
https://exercism.org/tracks/typescript
MIT License
148 stars 160 forks source link

Fix word-count #1309

Closed gregsadetsky closed 1 year ago

gregsadetsky commented 1 year ago

Fixes #1308

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

angelikatyborska commented 1 year ago

@SleeplessByte I believe this PR is needed after the sync (https://github.com/exercism/typescript/pull/1273), I didn't notice this detail

angelikatyborska commented 1 year ago

@gregsadetsky This PR needs one more change, one of those two:

You can run the tests against the example solution locally with ASSIGNMENT=practice/word-count yarn test

gregsadetsky commented 1 year ago

@angelikatyborska done -- I updated the CI test code to handle the case appropriately, thank you!

SleeplessByte commented 1 year ago

Re-opened to make the CI run.