search

exercism / typescript

Exercism exercises in TypeScript.
https://exercism.org/tracks/typescript
MIT License
148 stars 160 forks source link

Add a test for the edge case where the value is an empty string, two-fer #1429

Closed santi020k closed 8 months ago

santi020k commented 8 months ago

Although it's a very simple exercise, during a mentoring discussion, I found it interesting to consider the possibility of having this additional test, as it's a scenario that could happen in real life where a user might try to pass an empty string value. It's a very simple change; I just added an edge case to the two-fer tests. Feel free to reject this PR if you deem it necessary.

github-actions[bot] commented 8 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

SleeplessByte commented 8 months ago

Thank you for the PR.

We're not going to complicate two-fer, but discussing things like this during mentoring sessions is excellent!