search

exercism / unison

Exercism exercises in Unison.
https://exercism.org/tracks/unison
MIT License
3 stars 19 forks source link

etl: use `==` for Map comparison in tests #92

Open dreig opened 1 year ago

dreig commented 1 year ago

Use == in tests as it compares the contents of the maps, instead of === which is more strict as requires the two objects to be structurally identical, and may fail depending on how the maps were constructed. https://share.unison-lang.org/@unison/p/code/latest/terms/public/base/latest/data/Map/%3D%3D

The following solution was failing on the second test:

etl.transform : Map Nat [Char] -> Map Char Nat
etl.transform lettersByScore = 
  use Char toLowercase
  fn mp score chars = List.foldLeft (acc ch -> Map.put (toLowercase ch) score acc) mp chars
  Map.foldLeftWithKey fn Map.empty lettersByScore
github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link%20mp%20chars%0D%0A%20%20Map.foldLeftWithKey%20fn%20Map.empty%20lettersByScore%0D%0A%60%60%60&category=unison) to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

rlmark commented 1 year ago

Thank you @dreig! I'm reopening this and have requested that community contributions be accepted for this repo here.