search

exercism / v2-configlet

Tool to assist in managing Exercism language tracks.
MIT License
16 stars 23 forks source link

lint: refactoring for higher abstractions #109

Closed ferhatelmas closed 6 years ago

ferhatelmas commented 7 years ago

Implementation of checkers in lint command started to be repetitive. This tries to create an abstraction to make adding a new checker easier.

petertseng commented 7 years ago

I subscribe, so that if this is merged before #98 I get notified that I should rebase #98.

ferhatelmas commented 7 years ago

@petertseng sorry, I had thought you're already checking all PRs in this repo :wink: but I should have notified you anyway.

nywilken commented 6 years ago

@ferhatelmas I see there hasn't been any movement on this PR since November. Do you think you will have time to address @kytrinyx comments? If not we can close for now and revisit a restructure at a later time. Let me know. Thanks!

ferhatelmas commented 6 years ago

@nywilken It went out of scope. @kytrinyx gave wonderful review. I will address them and come back with a newer one. Thanks for taking care of repo.