search

exercism / v2-configlet

Tool to assist in managing Exercism language tracks.
MIT License
16 stars 23 forks source link

Add Upgrade command #118

Closed nywilken closed 6 years ago

nywilken commented 6 years ago

This change introduces a command for upgrading to the latest available version of Configlet. The upgrade command, is identical to the upgrade command used in the Exercism CLI. In fact, the underlying pkg github.com/exercism/cli/cli is being pulled into Configlet to download and upgrade the Configlet binary in-place. This change resolves #112

Note: The pkg version of github.com/exercism/cli/cli is currently pinned to the Nextercism branch.

Follow-Up: The existing pkg structure of github.com/exercism/cli/cli seems a bit strange so I think a follow up, in the near future, might be to restructure the pkg or even break it out of exercism/cli into its own pkg for upgrading GitHub released binaries.

nywilken commented 6 years ago

@kytrinyx thanks for the review.

I'm not super happy with having to pull in three packages from exercism/cli—and that we also have to hard-code the release url twice.

The release URL being in there twice is a complete oversight on my part. I'll cleaned things up and pushed a new change.

Regarding the three packages, I was thinking about using the ignored property in GoDep since we don't actually use config or debug to reduce the dependency graph, but wasn't sure if it would confuse things. I updated the Gopkg.* files in my latest push. Let me know what you think.

I think your idea of a completely separate package (something like exercism/ghrelease or exercism/ghpkg maybe?).

I like exercism/ghrelease. Breaking it out could be a good experiment and could be a first step in building a pkg for managing binaries through GitHub releases.

nywilken commented 6 years ago

If you have the time to take a stab at a ghrelease package, I think that would be a neat experiment.

@kytrinyx I saw this comment but never got around to responding. I will definitely give this a shot and keep you posted on the progress. BTW github/hub is sick. Thanks for introducing me to it.

kytrinyx commented 6 years ago

BTW github/hub is sick.

Yes! It's so good. The GitHub API is great and all, but the CLI does so much to make it easy to work against the API.

I will definitely give this a shot and keep you posted on the progress.

Sweet. No hurry, obviously :) I've been struggling just to keep up with emails, much less actually make progress on stuff.