search

exercism / v2-configlet

Tool to assist in managing Exercism language tracks.
MIT License
16 stars 23 forks source link

implement the --diff flag for the fmt command #150

Closed danielj-jordan closed 6 years ago

danielj-jordan commented 6 years ago

148

I am a bit new to Go and eager for any comments. Thanks

danielj-jordan commented 6 years ago

@nywilken @kytrinyx Thanks for the feedback. I have incorporated all your recommendations and squashed the commit.

danielj-jordan commented 6 years ago

I want to confirm that the flag should be named —test not —dry-run. Please reply and confirm. Thank you

kytrinyx commented 6 years ago

@danielj-jordan thank you for confirming. Yes! We're going with --test rather than --dry-run.

Also, the command should

  1. set verbose to true even if verbose wasn't passed, and
  2. exit with a non-zero code if something needs changing
danielj-jordan commented 6 years ago

@kytrinyx @nywilken I am not sure if you got notified, but the —test flag is implemented. It always runs with verbose.

kytrinyx commented 6 years ago

@danielj-jordan Ah, nope! I didn't see the notification. Thanks so much, I'll take a look at this in the morning.

danielj-jordan commented 6 years ago

@kytrinyx I moved the declaration closer. Thanks