exercism / v3

The work-in-progress project for developing v3 tracks
https://v3.exercism.io
Other
170 stars 162 forks source link

[Python] Add new concept exercise : numbers #2875

Closed Limm-jk closed 3 years ago

Limm-jk commented 3 years ago

Hello, this is our group's first contribution. We've created a new exercise about Concepts 'number'.(#2208)

I worked with OMEGA-Y / Yabby1997 / Ticktakto / wnstj2007

Any guidance is appreciated!

valentin-p commented 3 years ago

Awesome. Thanks for the PR, it looks great.

Couple of things:

That was my comments to help the PR be approved. I will let the maintainers add more comments if necessary.

Yabby1997 commented 3 years ago

Awesome. Thanks for the PR, it looks great.

Couple of things:

  • An object can be added in the file languages\python\config.json under: exercises.concept with the new slug: "currency-exchange" and a new uuid.
  • Prettier can be run on each file (.config, .md and .py) before a commit.

That was my comments to help the PR be approved. I will let the maintainers add more comments if necessary.

Thanks for your feedback!

We will review your feedback and revise it soon.

OMEGA-Y commented 3 years ago

Overall, this is great! Thank you so much for taking this on, and apologies for the long delay in getting all of you feedback. 😳

I've made some (mostly minor) language suggestions. All of them are suggestions - so you don't have to accept the change if it doesn't make sense, or doesn't "read" well to you.

I've also left a few comments in the test file.

Finally, I'd like to request that you add a task for the student around using the modulus operator and/or calculating remainders. I think % is an important tool in Python, and lends itself well to this currency exchange exercise.

Thank you for reviewing! We will consider your comments and revise it soon :)

BethanyG commented 3 years ago

Excellent work everyone! Thank you all for your time and effort. 🌟 🎉