Closed ErikSchierboom closed 3 years ago
I kinda like it when all exercises always have all concept heading. It's consistent and neatly structured. Can I keep Elixir's?
I still don't really get where we are because we've had so many changes to these files
concepts/...
exercises/...
introduction.md.tpl
to the Exercise, which will "import" the Concept's introduction to avoid duplication. (configlet will provide a command for syncing the template file).There's no magic of headings or anything like that at all now.
This PR effectively is just tidying things back up.
I kinda like it when all exercises always have all concept heading. It's consistent and neatly structured. Can I keep Elixir's?
Yes. That's fine. Tracks can decide. I personally prefer without as there is already an "Introduction" heading that these sit under the UI and I don't love headings followed by headings. But I don't think we should enforce a standard here.
@ErikSchierboom - could you change this PR for Elixir, please, so that it doesn't remove first-line headings.
@ErikSchierboom - could you change this PR for Elixir, please, so that it doesn't remove first-line headings.
I can. But just to be sure, you still want that @angelikatyborska after reading:
Yes. That's fine. Tracks can decide. I personally prefer without as there is already an "Introduction" heading that these sit under the UI and I don't love headings followed by headings. But I don't think we should enforce a standard here.
?
edit: it might also be good to see what it looks like in the UI
Thanks for the reviews!
@angelikatyborska I've created an exception for Elixir to add the headings to introductions for exercises with just one concept
Now that we no longer require the
introduction.md
file to have headings for the concepts, we can now clean the existingintroduction.md
files up a bit. In this PR, I've done two things: