search

exercism / v3

The work-in-progress project for developing v3 tracks
https://v3.exercism.io
Other
170 stars 164 forks source link

Convert example to exemplar #3086

Closed ErikSchierboom closed 3 years ago

ErikSchierboom commented 3 years ago

A while back there was a discussion on the name of the example files. For Concept Exercises, they are not just an example, but they are the exemplar solution.

Having not yet exploded this repo, we decided to do this renaming now. I've tried to script all the changes, but the word "Example" is used rather a lot :) If there are things obviously wrong or missing, please let me know.

We will be merging this PR before the exploding, so there is relatively little time to review. Sorry about that!

In this PR I'll update the v3-docs documentation.

mpizenberg commented 3 years ago

Related question, must we use the "examplar" name? In Elm, files must be named like their module declaration, and the module declaration does not use "Examplar" but a name appropriate for the module (same as the one in src/). So for a valid Elm file, it should be named "ModuleName.elm" and not "Examplar.elm". But in the meantime, the name of that file matters less than its content for its role. So my question is can we keep modules names or should we used "Examplar.elm"?

ErikSchierboom commented 3 years ago

Related question, must we use the "examplar" name? In Elm, files must be named like their module declaration, and the module declaration does not use "Examplar" but a name appropriate for the module (same as the one in src/). So for a valid Elm file, it should be named "ModuleName.elm" and not "Examplar.elm". But in the meantime, the name of that file matters less than its content for its role. So my question is can we keep modules names or should we used "Examplar.elm"?

Good question. I think for now we do, but we'll keep your remark in mind when implementing. CC @iHiD

mpizenberg commented 3 years ago

Sorry for the double rename (bad english on my part)

ErikSchierboom commented 3 years ago

Thanks for the reviews!