exercism / v3

The work-in-progress project for developing v3 tracks
https://v3.exercism.io
Other
170 stars 162 forks source link

[C#] Implement new Concept Exercise: integral-numbers #780

Closed NextNebula closed 4 years ago

NextNebula commented 4 years ago

This issue describes how to implement the integral-numbers concept exercise for the C# track.

Getting started

Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents:

Goal

The goal of this exercise is to teach the student the basics of the Concept of Integral Numbers in C#.

Learning objectives

Out of scope

Concepts

This Concepts Exercise's Concepts are:

Prequisites

This Concept Exercise's prerequisites Concepts are:

Resources to refer to

Hints

After

Representer

This exercise does not require any specific representation logic to be added to the representer.

Analyzer

This exercise does not require any specific analyzer logic to be added to the analyzer.

Implementing

To implement this exercise, please follow these instructions.

Help

If you have any questions while implementing the exercise, please post the questions as comments in this issue.

ErikSchierboom commented 4 years ago

I just realized that it would be great if this exercise can also introduce the various forms of integer literals: normal, hexadecimal and binary. As well as introducing the digit separator (_) character.

ErikSchierboom commented 4 years ago

@EarthlingRich I've updated this issue to conform to the latest in Concept naming and issue contents. Progressive insight has suggested that also introducing overflows might be a bit much, so I've created a separate exercise to cover that Concept.

Let me know if you have any questions and if you are still interested in working on this.

ErikSchierboom commented 4 years ago

This issue should not have been closed as it has not yet been implemented :)

mikedamay commented 4 years ago

@EarthlingRich please consider introducing primitive explicit casts here. I think they fit better here than in explicit-casts. Let me know what you think.

mikedamay commented 4 years ago

Hi @NextNebula. I’m not sure if you’ve kept up with the v3 progress on the C# track but we’re in the process of finishing off a bunch of introductory exercises and it would great if we could include the integral-numbers exercise to which you are currently assigned.

If you think you will be in a position to work on this in the next couple of weeks then please let us know and we will set our expectations accordingly. If not, could you let us know and we’ll be happy to reassign the exercise. We appreciate both good intentions and how life gets in the way so no worries.

If you have any uncommitted work that you think we could use or cannibalize then please let us know.

mikedamay commented 4 years ago

Hi @NextNebula. I’m proposing to reassign this issue (following the above comment). If you come across this in the next few days and want to take ownership again then please leave a comment. In any case, I hope you have the opportunity to work on the project sometime soon. It is very worth while.

mikedamay commented 4 years ago

closed by PR #2105

ErikSchierboom commented 4 years ago

Thanks for working on this @mikedamay!